Revert "fix: insert array into json column" #5431
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit dc6dbbf.
|
I'm not sure how to write a database specific test, but if someone can point me in the correct direction, I'd be interested in contributing a postgres specific array column test to prevent this regression in the future. (I'd also love to see this merged and deployed soon, so we can clear the CVE and still have working code.) |
|
@loren138 See https://github.com/knex/knex/blob/master/test/integration2/query/select/where.spec.js for isPostgreSQL/isMySQL checks |
|
Added a test here (though I need approval before the workflows can run): #5439 |
|
This change was included in #5439 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #5321
Fix #5365
Fix #5430