Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

run go.mod tidy - drop compat with 1.16 #12911

Merged
merged 1 commit into from May 4, 2022
Merged

run go.mod tidy - drop compat with 1.16 #12911

merged 1 commit into from May 4, 2022

Commits on May 4, 2022

  1. run go.mod tidy 

    go mod tidy -go=1.16 && go mod tidy -go=1.17
then
go mod tidy -compat=1.17

This was causing our downstream-test in knative.dev/pkg to fail
since go mod tidy was existing with an error code 1

Example output
```
knative.dev/serving/pkg/queue imports
        github.com/prometheus/client_golang/prometheus imports
        github.com/prometheus/procfs loaded from github.com/prometheus/procfs@v0.6.0,
        but go 1.16 would select v0.7.3
knative.dev/serving/cmd/activator imports
        go.uber.org/zap tested by
        go.uber.org/zap.test imports
        go.uber.org/goleak loaded from go.uber.org/goleak@v1.1.11-0.20210813005559-691160354723,
        but go 1.16 would select v1.1.12
knative.dev/serving/pkg/queue imports
        github.com/prometheus/client_golang/prometheus imports
        github.com/prometheus/procfs imports
        github.com/prometheus/procfs/internal/fs loaded from github.com/prometheus/procfs@v0.6.0,
        but go 1.16 would select v0.7.3
knative.dev/serving/pkg/queue imports
        github.com/prometheus/client_golang/prometheus imports
        github.com/prometheus/procfs imports
        github.com/prometheus/procfs/internal/util loaded from github.com/prometheus/procfs@v0.6.0,
        but go 1.16 would select v0.7.3
knative.dev/serving/cmd/activator imports
        go.uber.org/zap tested by
        go.uber.org/zap.test imports
        go.uber.org/goleak imports
        go.uber.org/goleak/internal/stack loaded from go.uber.org/goleak@v1.1.11-0.20210813005559-691160354723,
        but go 1.16 would select v1.1.12
knative.dev/serving/hack imports
        github.com/tsenart/vegeta/v12 imports
        github.com/tsenart/vegeta/v12/internal/resolver tested by
        github.com/tsenart/vegeta/v12/internal/resolver.test imports
        github.com/miekg/dns loaded from github.com/miekg/dns@v1.1.35,
        but go 1.16 would select v1.1.41
```
    @dprotaso
    dprotaso committed May 4, 2022
    Configuration menu
    Copy the full SHA
    53a3405 View commit details
    Browse the repository at this point in the history