run go.mod tidy - drop compat with 1.16 #12911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
go mod tidy -go=1.16 && go mod tidy -go=1.17
then
go mod tidy -compat=1.17
This was causing our downstream-test in knative.dev/pkg to fail
since go mod tidy was existing with an error code 1
Example output
```
knative.dev/serving/pkg/queue imports
github.com/prometheus/client_golang/prometheus imports
github.com/prometheus/procfs loaded from github.com/prometheus/procfs@v0.6.0,
but go 1.16 would select v0.7.3
knative.dev/serving/cmd/activator imports
go.uber.org/zap tested by
go.uber.org/zap.test imports
go.uber.org/goleak loaded from go.uber.org/goleak@v1.1.11-0.20210813005559-691160354723,
but go 1.16 would select v1.1.12
knative.dev/serving/pkg/queue imports
github.com/prometheus/client_golang/prometheus imports
github.com/prometheus/procfs imports
github.com/prometheus/procfs/internal/fs loaded from github.com/prometheus/procfs@v0.6.0,
but go 1.16 would select v0.7.3
knative.dev/serving/pkg/queue imports
github.com/prometheus/client_golang/prometheus imports
github.com/prometheus/procfs imports
github.com/prometheus/procfs/internal/util loaded from github.com/prometheus/procfs@v0.6.0,
but go 1.16 would select v0.7.3
knative.dev/serving/cmd/activator imports
go.uber.org/zap tested by
go.uber.org/zap.test imports
go.uber.org/goleak imports
go.uber.org/goleak/internal/stack loaded from go.uber.org/goleak@v1.1.11-0.20210813005559-691160354723,
but go 1.16 would select v1.1.12
knative.dev/serving/hack imports
github.com/tsenart/vegeta/v12 imports
github.com/tsenart/vegeta/v12/internal/resolver tested by
github.com/tsenart/vegeta/v12/internal/resolver.test imports
github.com/miekg/dns loaded from github.com/miekg/dns@v1.1.35,
but go 1.16 would select v1.1.41
```
knative-prow
bot
added
the
size/XXL
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
added
the
approved
|
/hold surprised to see a |
knative-prow
bot
added
the
do-not-merge/hold
Codecov Report
@@ Coverage Diff @@
## main #12911 +/- ##
=======================================
Coverage 87.04% 87.04%
=======================================
Files 197 197
Lines 14437 14437
=======================================
Hits 12567 12567
Misses 1576 1576
Partials 294 294 Continue to review full report at Codecov.
|
|
Removed it here: prometheus/procfs#447 in the meantime |
knative-prow
bot
removed
the
do-not-merge/hold
do you need to wait for that? |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go mod tidy -go=1.16 && go mod tidy -go=1.17then
go mod tidy -compat=1.17This was causing our downstream-test in
knative.dev/pkgto failsince go mod tidy was exiting with an error code 1
Example output