Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly enable tracing in ci istio setup #7356

Merged
merged 1 commit into from
May 15, 2024

Conversation

nrfox
Copy link
Contributor

@nrfox nrfox commented May 15, 2024

Starting in 1.22, zipkin tracing is no longer enabled by default. Therefore, in our CI setup we need to explicitly enable it.

Starting in 1.22, zipkin tracing is no longer enabled by default. Therefore, in our CI setup we need to explicitly enable it.
@jshaughn jshaughn added test: front-end/cypress PR adds/updates front-end tests (unit and/or cypress automation ) test: back-end/integration PR adds/updates back-end tests (unit and/or integration) labels May 15, 2024
Copy link
Collaborator

@jshaughn jshaughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Nick, let's get this in and then worry about the Tempo issue.

@jshaughn jshaughn merged commit df1ae0f into kiali:master May 15, 2024
8 of 9 checks passed
@nrfox nrfox deleted the fix-tracing-in-ci-setup branch May 15, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test: back-end/integration PR adds/updates back-end tests (unit and/or integration) test: front-end/cypress PR adds/updates front-end tests (unit and/or cypress automation )
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants