Skip to content

Commit

Permalink
Explicitly enable tracing in ci istio setup (#7356)
Browse files Browse the repository at this point in the history
Starting in 1.22, zipkin tracing is no longer enabled by default. Therefore, in our CI setup we need to explicitly enable it.
  • Loading branch information
nrfox committed May 15, 2024
1 parent b0523f8 commit df1ae0f
Showing 1 changed file with 18 additions and 1 deletion.
19 changes: 18 additions & 1 deletion hack/istio/install-istio-via-istioctl.sh
Original file line number Diff line number Diff line change
Expand Up @@ -482,7 +482,10 @@ for s in \
"${CUSTOM_NAMESPACE_OPTIONS}" \
"--set values.gateways.istio-egressgateway.enabled=${ISTIO_EGRESSGATEWAY_ENABLED}" \
"--set values.gateways.istio-ingressgateway.enabled=${ISTIO_INGRESSGATEWAY_ENABLED}" \
"--set values.meshConfig.defaultConfig.tracing.sampling=100.00" \
"--set values.meshConfig.enableTracing=true" \
"--set values.meshConfig.extensionProviders[0].name=zipkin" \
"--set values.meshConfig.extensionProviders[0].zipkin.service=zipkin.${NAMESPACE}.svc.cluster.local" \
"--set values.meshConfig.extensionProviders[0].zipkin.port=9411" \
"--set values.meshConfig.accessLogFile=/dev/stdout" \
"${CNI_OPTIONS}" \
"${MESH_ID_OPTION}" \
Expand Down Expand Up @@ -553,6 +556,20 @@ else
done
done

# Enable tracing.
${CLIENT_EXE} apply -f - <<EOF
apiVersion: telemetry.istio.io/v1alpha1
kind: Telemetry
metadata:
name: mesh-default
namespace: ${NAMESPACE}
spec:
tracing:
- providers:
- name: "zipkin"
randomSamplingPercentage: 100.00
EOF

if [ "${K8S_GATEWAY_API_ENABLED}" == "true" ]; then
if [ "${K8S_GATEWAY_API_VERSION}" == "" ]; then
echo "Gateway API Version is not specified, taking the latest released version"
Expand Down

0 comments on commit df1ae0f

Please sign in to comment.