Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate new React App for Admin Next #760

Merged
merged 3 commits into from May 22, 2018
Merged

Conversation

kevinhughes27
Copy link
Owner

@kevinhughes27 kevinhughes27 commented May 16, 2018

part of #750

This PR runs the create-react-app script to generate a new client along with all the build and development configuration. create-react-app is a project from Facebook to offer an abstracted and opinionated project setup for React applications. It hides away all the low level configuration and enables all the latest and greatest in Javascript development like hot reloading, small image in-lining, code splitting and more. It doesn't lock you in either since you can eject the abstracted configuration if you need to, however this will make updating to new versions harder.

For historic context create-react-app performs the same role as the Rails asset pipeline does. The main advantage is that it is actively maintained by frontend people instead of more or less being abandoned by backend people. Eventually we'll be able to remove the asset pipeline in this project and have separate toolchains for server and client projects.

create-react-app is nearing version 2 which includes a lot of great stuff but unfortunately its not ready yet. In the past they have provided very clear upgrade instructions. Since we're using typescript we'll also have to wait for the typescript fork to update.

cc @patrickkenzie @JRSpencer @RichardBlair

@kevinhughes27 kevinhughes27 mentioned this pull request May 16, 2018
@kevinhughes27
Copy link
Owner Author

btw I'm using VS Code as my editor for frontend projects now and Atom still for backend. VS Code has a lot of really nice things for Javascript and even more for Typescript

@kevinhughes27 kevinhughes27 merged commit 6061443 into master May 22, 2018
@kevinhughes27 kevinhughes27 deleted the admin-next-react-app branch May 22, 2018 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant