Add material ui #762
Merged
Add material ui #762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinhughes27
force-pushed
the
add-material-ui
branch
from
f50a89e
to
c1dbb07
Compare
kevinhughes27
force-pushed
the
add-material-ui
branch
from
c1dbb07
to
4e5fb6c
Compare
|
I should mention that I still know nothing about typescript. The things I fixed I did so by doing exactly what the error message said to do |
kevinhughes27
commented
May 23, 2018
| </div> | ||
| ); | ||
| } | ||
| } | ||
|
|
||
| export default App; | ||
| export default withRoot(withStyles(styles)<{}>(Index)); |
There was a problem hiding this comment.
I find this pretty ugly but I don't fully understand it yet so I haven't attempted to clean it up. I was able to only do this once and hide it for the player-app. I plan to leave it for now and look deeper when I work on the general app layout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #750
requires #760
I decided to go with Material UI for the component framework. Its the most popular and complete framework for React and its what I built the player-app with. It has typescript types so no extra work is required there. They even have some dashboard templates that I'll pull in next to get the UI started.
For this PR I just followed the example from Material UI https://github.com/mui-org/material-ui/tree/master/examples/create-react-app-with-typescript I had to make a few changes for the latest typescript rules but otherwise its more or less copy paste.
cc @patrickkenzie @JRSpencer @RichardBlair