Run e2e testnet tests via GHA, not Kubernetes #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalinacienciala
force-pushed
the
rfc-18/move-e2e-kubernetes-job-to-gha
branch
30 times, most recently
from
1f625f7
to
ec6794e
Compare
We've changed the names of the secrets and need to update the workflow configs accordingly. The change of secret name was introduced to differentiate between WS and HTTP urls.
We've started to tag the `tbtc.js` packages with the environment name. We no longer need to manually update the version of this package in the workflow file, instead we'll be allways using the latest version of the package and contracts migrated on `ropsten`.
We need to use a BTC account which has a non-zero BTC balance on testnet.
In order to save testnet BTC, we perform some optimizations in the e2e test. First, we open two deposits only when necessary to avoid locking to much of BTC. Secondly, we use the smallest possible lot size.
The bonds amount must cover the setup fee.
In the GitHub's settings, we've changed the name of the `KEEP_TEST_ETH_HOSTNAME` to `KEEP_TEST_ETH_HOSTNAME_WS` to differenciate between WS and HTTP urls. We need to update workflow config accordingly. This commit fixes the configuration incorrectly updated in the last commit.
In order to limit the amount of spent testnet BTC, we are changing the frequency of running the workflow. We will observe how does the daily execution affect the wallet's ballance and will further adjust the frequency of tests execution in the future.
Currently those errors are unhandled. Recent changes made in `tbtc.js` require to register an explicit error handler.
…o-gha' into rename-keep-test-eth-hostname-secret
…me-secret Rename KEEP_TEST_ETH_HOSTNAME env variable We've changed the names of the secrets and need to update the workflow configs accordingly. The change of secret name was introduced to differentiate between WS and HTTP urls.
Action now supports cases where `*.lock` file is located in the root's subdirectory.
This should help debugging problems with BTC and ETH client synchronization.
lukasz-zimnoch
force-pushed
the
rfc-18/move-e2e-kubernetes-job-to-gha
branch
from
5b284d0
to
f91b0e4
Compare
lukasz-zimnoch
force-pushed
the
rfc-18/move-e2e-kubernetes-job-to-gha
branch
from
8613299
to
673315e
Compare
In case of small amounts, the current 10% overhead is not enough. 20% should work in those cases.
nkuba
approved these changes
Aug 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were running E2E tests on testnet (Ropsten) using Kubernetes. But as
the GitHub Actions provide better visibility for the tests results, we
decided to move the testing job there.
The
e2e-testnet.ymlhas been created and the old Kubernetes config hasbeen removed.
The currently proposed solution is not ideal. It requires manual
updating of the
tbtc.jsversion in the workflow config every timenew contracts get released. In the future we plan to do that
automatically.