Rename KEEP_TEST_ETH_HOSTNAME env variable #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've changed the names of the secrets and need to update the workflow configs accordingly. The change of secret name was introduced to differentiate between WS and HTTP urls.
This was referenced Jul 28, 2021
nkuba
approved these changes
Aug 4, 2021
nkuba
requested changes
Aug 4, 2021
.github/workflows/e2e-testnet.yml
Outdated
| @@ -38,7 +38,7 @@ jobs: | |||
| - name: Run e2e tests | |||
| run: | | |||
| ./e2e-test.js \ | |||
| --bitcoin-electrum-host=${{ secrets.KEEP_TEST_ELECTRUMX_HOSTNAME }} \ | |||
| --bitcoin-electrum-host=${{ secrets.KEEP_TEST_ELECTRUMX_HOSTNAME_WS }} \ | |||
There was a problem hiding this comment.
We don't need to change this. We updated only KEEP_TEST_ETH_HOSTNAME to KEEP_TEST_ETH_HOSTNAME_WS.
In the GitHub's settings, we've changed the name of the `KEEP_TEST_ETH_HOSTNAME` to `KEEP_TEST_ETH_HOSTNAME_WS` to differenciate between WS and HTTP urls. We need to update workflow config accordingly. This commit fixes the configuration incorrectly updated in the last commit.
…o-gha' into rename-keep-test-eth-hostname-secret
michalinacienciala
changed the title
nkuba
approved these changes
Aug 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've changed the names of the secrets and need to update the workflow
configs accordingly. The change of secret name was introduced to
differentiate between WS and HTTP urls.
Depends on:
#98
Refs: