Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated tests_require from setup.py in Kedro-Airflow #55

Merged
merged 1 commit into from Aug 23, 2022
Merged

Remove deprecated tests_require from setup.py in Kedro-Airflow #55

merged 1 commit into from Aug 23, 2022

Conversation

cshaley
Copy link
Contributor

@cshaley cshaley commented Aug 22, 2022

Description

See issue #53

Development notes

I have removed tests_require from setup.py

Checklist

  • [NA] Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • [NA] Updated the documentation to reflect the code changes
  • [NA] Added a description of this change in the relevant RELEASE.md file
  • [NA] Added tests to cover my changes

@cshaley cshaley closed this Aug 22, 2022
@cshaley
Copy link
Contributor Author

cshaley commented Aug 22, 2022

Saw #54, closing

@deepyaman
Copy link
Member

deepyaman commented Aug 22, 2022 •
edited

Saw #54, closing

Ah, you're more than welcome to reopen this, and I'll close mine, if you'd like, since you opened the issue. :) I just started doing it absentmindedly during a call.

edit: @cshaley Actually, I'd be more than happy if you tried reopening and resolving the DCO (make sure you sign your commit, following the instructions), given I've been getting some weird build issues on https://github.com/kedro-org/kedro-plugins lately... possibly due to some bug handling repeated commit messages.

edit #2: @AntonyMilneQB points out that this may be because I'm editing multiple plugins at once, so feel free to just do it for kedro-airlfow as you've done now; I'll reopen, if you don't mind.

@deepyaman deepyaman reopened this Aug 22, 2022
deepyaman
deepyaman approved these changes Aug 22, 2022
View reviewed changes
Copy link
Member

@deepyaman deepyaman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to approve, given DCO gets fixed!

deepyaman
deepyaman reviewed Aug 22, 2022
View reviewed changes
kedro-airflow/setup.py Outdated Show resolved Hide resolved
@deepyaman deepyaman changed the title remove tests_require from setup.py because its deprecated Remove tests_require from setup.py because its deprecated Aug 22, 2022
@deepyaman deepyaman changed the title Remove tests_require from setup.py because its deprecated Remove deprecated tests_require from setup.py in Kedro-Docker Aug 22, 2022
@deepyaman deepyaman changed the title Remove deprecated tests_require from setup.py in Kedro-Docker Remove deprecated tests_require from setup.py in Kedro-Airflow Aug 22, 2022
@cshaley cshaley force-pushed the deprecate-setup-test branch 2 times, most recently from 5d72346 to 21a5a25 Compare August 22, 2022 16:28
@cshaley
remove tests_require from setup.py because its deprecated
24bae42 
comment consistency

Signed-off-by: cshaley <6740446+cshaley@users.noreply.github.com>
@cshaley
Copy link
Contributor Author

cshaley commented Aug 22, 2022

@deepyaman ok got DCO passed

antonymilne
antonymilne approved these changes Aug 22, 2022
View reviewed changes
Copy link
Contributor

@antonymilne antonymilne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much!

@cshaley
Copy link
Contributor Author

cshaley commented Aug 22, 2022

Any idea how long until next release once merged?

@deepyaman deepyaman merged commit be05922 into kedro-org:main Aug 23, 2022
jmholzer pushed a commit that referenced this pull request Aug 24, 2022
@cshaley @jmholzer
Remove deprecated tests_require from setup.py in Kedro-Airflow (#55)
b693dd8 
comment consistency

Signed-off-by: cshaley <6740446+cshaley@users.noreply.github.com>

Signed-off-by: cshaley <6740446+cshaley@users.noreply.github.com>
@cshaley cshaley mentioned this pull request Aug 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepyaman deepyaman deepyaman approved these changes

@antonymilne antonymilne antonymilne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cshaley @deepyaman @antonymilne