Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kedro-airflow setup.py requires test_requirements.txt, but it's not packaged in pypi #53

Closed
cshaley opened this issue Aug 22, 2022 · 3 comments

Comments

@cshaley
Copy link
Contributor

cshaley commented Aug 22, 2022

Description

Kedro-airflow setup.py requires test_requirements.txt, but it's not packaged in pypi

Context

I am trying to package kedro-airflow and kedro-viz for conda-forge so that I can conda install them. Conda-forge runs setup.py as part of the build process. Kedro-airflow directly references test_requirements.txt in setup.py, but test_requirements.txt is not packaged in the build for pypi, so running setup.py fails.

Steps to Reproduce

  1. Download kedro-airflow via pypi.
  2. unzip it and run python setup.py.

Expected Result

Setup.py succeeds.

Actual Result

Setup.py fails because test_requirements.txt is missing.

 FileNotFoundError: [Errno 2] No such file or directory: 'test_requirements.txt'
@deepyaman
Copy link
Member

@cshaley Thanks for the report! My opinion is that test_requires and the associated python setup.py test are both pretty useless/deprecated, and we don't use that in the CI anyway (thankfully), so the easiest solution is to just kill them. :)

Deprecation references:

@cshaley
Copy link
Contributor Author

cshaley commented Aug 22, 2022

Note: same thing is true of Kedro-viz. I'm also looking to package it on conda forge but this issue got in the way. @deepyaman Shall I open an issue there as well?

@cshaley
Copy link
Contributor Author

cshaley commented Aug 25, 2022

Resolved by #55

@cshaley cshaley closed this as completed Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants