Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kedro-viz setup.py requires test_requirements.txt, but it's not packaged in pypi #1028

Closed
cshaley opened this issue Aug 22, 2022 · 1 comment

Comments

@cshaley
Copy link
Contributor

cshaley commented Aug 22, 2022

Description

Kedro-viz setup.py requires test_requirements.txt, but it's not packaged in pypi

Context

I am trying to package kedro-viz and kedro-airflow for conda-forge so that I can conda install them. Conda-forge runs setup.py as part of the build process. Kedro-viz directly references test_requirements.txt in setup.py, but test_requirements.txt is not packaged in the build for pypi, so running setup.py fails.

Steps to Reproduce

  1. Download kedro-viz via pypi.
  2. unzip it and run python setup.py.

Expected Result

Setup.py succeeds.

Actual Result

Setup.py fails because test_requirements.txt is missing.

 FileNotFoundError: [Errno 2] No such file or directory: 'test_requirements.txt'

See kedro-airflow Issue 53.

Deprecation references:

pypa/setuptools#1684
pytest-dev/pytest#5534

@cshaley cshaley changed the title <Title> Kedro-viz setup.py requires test_requirements.txt, but it's not packaged in pypi Aug 22, 2022
@tynandebold
Copy link
Member

Fixed with #1029

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants