Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(test): test:client silently failing on Travis #3343

Merged
merged 2 commits into from
Jul 26, 2019
Merged

fix(test): test:client silently failing on Travis #3343

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5aa3d1e
fix(test): ensure that grunt test:client exits with non-zero code
devoto13 May 25, 2019
1268617
fix(test): adjust assertions to work in latest Chrome
devoto13 Jul 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion tasks/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ module.exports = function (grunt) {

function exec (args, failMsg) {
spawnKarma(args, function (err, result, code) {
if (code) {
if (code || err) {
console.error(err)
grunt.fail.fatal(failMsg, code)
} else {
Expand Down
4 changes: 2 additions & 2 deletions test/e2e/error.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ Feature: Error Display
When I start Karma
Then it fails with:
"""
SyntaxError: Unexpected token }
SyntaxError: Unexpected token '}'
"""
Scenario: Not single-run Syntax Error in a test file
Given a configuration with:
Expand All @@ -32,5 +32,5 @@ Feature: Error Display
When I runOut Karma
Then it fails with like:
"""
SyntaxError: Unexpected token }
SyntaxError: Unexpected token '}'
"""