Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(test): test:client silently failing on Travis #3343

Merged
merged 2 commits into from
Jul 26, 2019
Merged

fix(test): test:client silently failing on Travis #3343

merged 2 commits into from
Jul 26, 2019

Commits on Jul 26, 2019

  1. fix(test): ensure that grunt test:client exits with non-zero code 

    Apparently it is not enough to check `code`, because when process
crashes `code` is set to `null` and `err` is passed instead.

Example of failing tests, which didn't fail build:
https://travis-ci.org/karma-runner/karma/jobs/537027667#L1046
    @devoto13
    devoto13 committed Jul 26, 2019
    Configuration menu
    Copy the full SHA
    5aa3d1e View commit details
    Browse the repository at this point in the history

  2. fix(test): adjust assertions to work in latest Chrome

    @devoto13
    devoto13 committed Jul 26, 2019
    Configuration menu
    Copy the full SHA
    1268617 View commit details
    Browse the repository at this point in the history