Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hash jwks keys by kid #349

Closed
wants to merge 6 commits into from
Closed

Hash jwks keys by kid #349

wants to merge 6 commits into from

Commits on Jul 7, 2020

  1. Add specs to show that parsed JSON doesn't work

    @martinemde
    martinemde committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    d5848a3 View commit details
    Browse the repository at this point in the history

  2. JWK loading of string keys from parsed JSON 

    This fixes an issue where JSON.parse results of an actual .jwks file
fail to import into the key finder because they have string keys.

Errors also improved in a way that helps debugging issues with JWKS loading.
    @martinemde
    martinemde committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    0b89eba View commit details
    Browse the repository at this point in the history

  3. single quoted strings

    @martinemde
    martinemde committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    adadefb View commit details
    Browse the repository at this point in the history

  4. Offer a sacrifice to the code climate gods

    @martinemde
    martinemde committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    c5b39f0 View commit details
    Browse the repository at this point in the history

  5. Does this make code climate happy?

    @martinemde
    martinemde committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    7ed6848 View commit details
    Browse the repository at this point in the history

  6. Hash jwks by kid for quick lookup 

    Assuming here that lookup by kid happens much more often than reloading,
so there is a slight benefit to not searching the array every time.

Note that I only did this because code climate was complaining.
This could be analyzed separately from my big fix.
    @martinemde
    martinemde committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    5bef2e1 View commit details
    Browse the repository at this point in the history