Hash jwks keys by kid #349
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcelevel-bot[bot]](https://avatars.githubusercontent.com/in/597?s=60&v=4){kind=small}
| return find_key(kid) | ||
| end | ||
| jwk = jwks[kid] | ||
| jwk ||= reload && jwks[kid] |
There was a problem hiding this comment.
Useless assignment to variable - jwk. Use || instead of ||=.
| key_n = decode_open_ssl_bn(jwk_n) | ||
| key_e = decode_open_ssl_bn(jwk_e) | ||
|
|
||
| if key.respond_to?(:set_key) |
There was a problem hiding this comment.
JWT::JWK::RSA#self.rsa_pkey manually dispatches method call
|
SourceLevel has finished reviewing this Pull Request and has found:
|
This fixes an issue where JSON.parse results of an actual .jwks file fail to import into the key finder because they have string keys. Errors also improved in a way that helps debugging issues with JWKS loading.
Assuming here that lookup by kid happens much more often than reloading, so there is a slight benefit to not searching the array every time. Note that I only did this because code climate was complaining. This could be analyzed separately from my big fix.
|
As discussed in #348, I realize this keyloader is short-lived and so the optimization here does nothing. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #348.
I found this improvement when trying to make the code better for fetching keys by kid. You can see it's a little messy in my other branch and cleaner here.
I separated it into another PR since this refactor changes things unrelated to parsing string keys.