Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore horizontal scrolling of outputs for Firefox #15171
Restore horizontal scrolling of outputs for Firefox #15171
Changes from 11 commits
8af4994
f0b11d7
923697d
7582a36
7ad6d82
cb0a830
2a295cd
aadfb1f
ca63bd9
fb079b7
1a1821f
17b9cda
45b318d
744ac32
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check failure on line 24 in galata/test/jupyterlab/notebook-mobile.test.ts
GitHub Actions / Visual Regression Tests
[jupyterlab] › test/jupyterlab/notebook-mobile.test.ts:15:7 › Notebook Layout on Mobile › Execute code cell
Check failure on line 24 in galata/test/jupyterlab/notebook-mobile.test.ts
GitHub Actions / Visual Regression Tests
[jupyterlab] › test/jupyterlab/notebook-mobile.test.ts:15:7 › Notebook Layout on Mobile › Execute code cell
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jtpio is this good enough or should we shrink top/bottom margins back to closer match the previous snapshot?
A part of me things that maybe the larger spacing is good for mobile (and possibly even required by accessibility) because the tap targets are easier to separate. I do not have a strong opinion though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good on the new screenshot. Actually a bit more spacing makes it a bit more pleasant to read it seems.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure there was a specific reason for having the margins very small on mobile in the first place, maybe it was just a side-effect of the table layout.