Restore horizontal scrolling of outputs for Firefox

[fcollonval]

References

Fixes #14625

Code changes

It revert the changes done in #11508 to apply them only when printing
It adds the generation of a test notebook for printing

User-facing changes

Horizontal scroll on FireFox is restored

Backwards-incompatible changes

None

[jupyterlab-probot]

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link:

[krassowski]

It looks this also breaks the mobile layout, or at least a test for it:

And Vega outputs positioning changes:

[krassowski]

I finished up the fix for the mobile layout and reverted snapshot updated for mobile-layout-jupyterlab-linux.png.

The Vega change is probably expected and a result of:

jupyterlab/packages/vega5-extension/style/base.css

Lines 6 to 9 in 0b33a5c

	.jp-RenderedVegaCommon5 {
	margin-left: 8px;
	margin-top: 8px;
	}

and

Note that Firefox disregards the margin-left and margin-right rules because it doesn't apply them to elements with style display: table-cell, like this one. #12378 (comment)

I do not have a strong opinion on spacing so I guess it is fine to keep. I would say that if CI passes this is good to merge.

[krassowski]

@jtpio is this good enough or should we shrink top/bottom margins back to closer match the previous snapshot?

A part of me things that maybe the larger spacing is good for mobile (and possibly even required by accessibility) because the tap targets are easier to separate. I do not have a strong opinion though.

[jtpio]

Looks good on the new screenshot. Actually a bit more spacing makes it a bit more pleasant to read it seems.

Thanks!

[jtpio]

I'm not sure there was a specific reason for having the margins very small on mobile in the first place, maybe it was just a side-effect of the table layout.

[krassowski]

bot please update galata snapshots

[github-actions]

Galata snapshots updated.

[krassowski]

All 💚 now. Thank you @fcollonval!

[jtpio]

Nice, thanks!

[jtpio]

@meeseeksdev please backport to 4.0.x

[lumberbot-app]

Something went wrong ... Please have a look at my logs.

It seems that the branch you are trying to backport to does not exist.

[jtpio]

@meeseeksdev please backport to 4.0.x