Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to releaser v2 #13322

Merged
merged 10 commits into from Oct 27, 2022
Merged

Switch to releaser v2 #13322

merged 10 commits into from Oct 27, 2022

Conversation

blink1073
Copy link
Member

References

Updates JupyterLab to be compatible with Jupyter Releaser v2

Code changes

Updates workflows and releaser config.

User-facing changes

None

Backwards-incompatible changes

None

@jupyterlab-probot
Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

@blink1073 blink1073 marked this pull request as ready for review October 27, 2022 12:39
@blink1073 blink1073 requested a review from jtpio October 27, 2022 12:39
@jtpio jtpio added this to the 4.0.0 milestone Oct 27, 2022
@jtpio
Copy link
Member

jtpio commented Oct 27, 2022

For reference there is a section in the mdformat docs about the differences between mdformat and prettier: https://mdformat.readthedocs.io/en/stable/#why-not-use-prettier-instead

@jtpio jtpio mentioned this pull request Oct 27, 2022
Closed
@blink1073
Copy link
Member Author

We also needed mdformat because releaser uses it to format the changelog, which caused the pre-commit check to fail when prettier tried to alter it.

@jtpio
Copy link
Member

jtpio commented Oct 27, 2022

This might then also fix #12671

@jtpio jtpio mentioned this pull request Oct 27, 2022
Closed
jtpio
jtpio approved these changes Oct 27, 2022
View reviewed changes
Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jtpio jtpio merged commit f1bc627 into jupyterlab:master Oct 27, 2022
@blink1073
Copy link
Member Author

@meeseeksdev please backport to 3.6.x

@blink1073 blink1073 deleted the releaser-v2 branch October 27, 2022 14:15
@lumberbot-app
Copy link

lumberbot-app bot commented Oct 27, 2022

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 3.6.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 f1bc627a2554f6171f476a1b11650e9e3fab2732
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #13322: Switch to releaser v2'
  1. Push to a named branch:
git push YOURFORK 3.6.x:auto-backport-of-pr-13322-on-3.6.x
  1. Create a PR against branch 3.6.x, I would have named this PR:

"Backport PR #13322 on branch 3.6.x (Switch to releaser v2)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

blink1073 added a commit to blink1073/jupyterlab that referenced this pull request Oct 27, 2022
@blink1073
Switch to releaser v2 (jupyterlab#13322)
391ae5d 
* switch to releaser v2

* fix workflow

* more cleanup

* use hatch for cli

* install dev deps

* fix changelog and move bump2version to dev deps

* use hatchling version in buildapi

* another hatchling version

* use mdformat

* fix linter

(cherry picked from commit f1bc627)
jtpio pushed a commit that referenced this pull request Oct 28, 2022
@blink1073
Backport PR #13322 on branch 3.6.x (Switch to releaser v2) (#13327)
5ad820d 
* Switch to releaser v2 (#13322)

* switch to releaser v2

* fix workflow

* more cleanup

* use hatch for cli

* install dev deps

* fix changelog and move bump2version to dev deps

* use hatchling version in buildapi

* another hatchling version

* use mdformat

* fix linter

(cherry picked from commit f1bc627)

* lint

* fix changelog

* add ignore link
@lumberbot-app lumberbot-app bot mentioned this pull request Oct 28, 2022
Merged
hukkin
hukkin reviewed Oct 28, 2022
View reviewed changes
RELEASE.md
- [ ] Modify and run `python scripts/milestone_check.py` to check the issues assigned to this milestone
- [ ] Write [release highlights](CHANGELOG.md), starting with:
- \[ \] Modify and run `python scripts/milestone_check.py` to check the issues assigned to this milestone
- \[ \] Write [release highlights](CHANGELOG.md), starting with:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @blink1073 👋 !

You may want to add some plugins to avoid mangling non-CommonMark syntax such as these task lists.

A PR such as this one should do the trick jupyter-server/enterprise_gateway#1172

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! #13335

@blink1073 blink1073 mentioned this pull request Oct 28, 2022
Merged
@blink1073 blink1073 mentioned this pull request Nov 4, 2022
Closed
@jtpio jtpio mentioned this pull request Feb 24, 2023
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hukkin hukkin hukkin left review comments

@jtpio jtpio jtpio approved these changes

Assignees

@blink1073 blink1073

Labels
documentation maintenance pkg:services pkg:ui-components tag:Design and UX tag:Examples tag:Testing
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@blink1073 @jtpio @hukkin