Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pre-commit with the Jupyter Releaser #12671

Closed
jtpio opened this issue Jun 8, 2022 · 1 comment
Closed

pre-commit with the Jupyter Releaser #12671

jtpio opened this issue Jun 8, 2022 · 1 comment
Labels

Comments

@jtpio
Copy link
Member

jtpio commented Jun 8, 2022

Description

In #12662 (comment), we noticed that a trailing space in a PR title make the pre-commit check fail when committing the changelog.

Although the commit failed, the Draft Changelog workflow still passed and was marked as successful.

Reproduce

See:

image

Expected behavior

During a release the draft changelog workflow should be able to commit the changes automatically even if this triggers prettier changes.

Normally pre-commit requires re-adding the changed files, but this should be automatically be done during a release.

Context

#12662 (comment)

@jtpio jtpio added bug status:Needs Triage Applied to new issues that need triage and removed status:Needs Triage Applied to new issues that need triage labels Jun 8, 2022
@jtpio
Copy link
Member Author

jtpio commented Feb 24, 2023

Closing as most likely fixed by #13322.

The changelog is formatted with mdformat here: https://github.com/jupyter-server/jupyter_releaser/blob/2ef7b7f60aef425273afe039f0f7b3651f193a5a/jupyter_releaser/lib.py#L500

Also the package is now not installed by releaser v2 anymore (which used to pip install -e ".[dev]"): jupyter-server/jupyter_releaser#449
Which means pre-commit and the pre-commit hooks should not be installed anymore and not trigger the issue mentione above.

Feel free to reopen if someone notices this issue while making a new release of JupyterLab.

@jtpio jtpio closed this as completed Feb 24, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant