-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trust dialog link styling, text changes #11827
Conversation
Thanks for making a pull request to jupyterlab! |
One backward-compatible way would be to add a selector only for dialogs and use the same styling as we already use in rendered markdown (blue colour but no underline). |
…styling) except where this class is present
Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Benchmark reportThe execution time (in milliseconds) are grouped by test file, test type and browser. The mean relative comparison is computed with 95% confidence. Results table
Changes are computed with expected as reference. |
Updates the link styling in UI components such as the Trust dialog. Updates the text in the Trust dialog's body. Updates the primary action button to be "Trust" instead of "Ok" to match text of dialog box.
References
See #10837.
Code changes
Removes link styling overrides that make links visually indistinct from text. Updates dialog body and button text.
User-facing changes
After change, note:
Backwards-incompatible changes
None.