Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trust dialog link styling, text changes #11827

Merged
merged 8 commits into from Jan 21, 2022

Conversation

JasonWeill
Copy link
Contributor

Updates the link styling in UI components such as the Trust dialog. Updates the text in the Trust dialog's body. Updates the primary action button to be "Trust" instead of "Ok" to match text of dialog box.

References

See #10837.

Code changes

Removes link styling overrides that make links visually indistinct from text. Updates dialog body and button text.

User-facing changes

After change, note:

  1. "Trust" (in quotes) in the dialog body
  2. Primary action button renamed from "Ok" to "Trust"
  3. "the Jupyter security documentation" link is now visually distinct from the rest of the dialog box's body.

image

Backwards-incompatible changes

None.

@jupyterlab-probot
Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

@github-actions github-actions bot added Design System CSS pkg:notebook pkg:ui-components tag:CSS For general CSS related issues and pecadilloes labels Jan 11, 2022
@JasonWeill JasonWeill added bug and removed pkg:notebook tag:CSS For general CSS related issues and pecadilloes Design System CSS labels Jan 11, 2022
@jtpio jtpio added this to the 4.0 milestone Jan 12, 2022
@krassowski
Copy link
Member

One backward-compatible way would be to add a selector only for dialogs and use the same styling as we already use in rendered markdown (blue colour but no underline).

Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

Benchmark report

The execution time (in milliseconds) are grouped by test file, test type and browser.
For each case, the following values are computed: min <- [1st quartile - median - 3rd quartile] -> max.

The mean relative comparison is computed with 95% confidence.

Results table
Test file large_code_notebook large_md_notebook
open
chromium
actual 4348 <- [4463 - 4547 - 4773] -> 5602 2888 <- [2969 - 3037 - 3148] -> 3998
expected 4223 <- [4386 - 4423 - 4483] -> 4806 2861 <- [2919 - 2960 - 2986] -> 3148
Mean relative change 4.8% ± 1.3% 5.3% ± 1.6%
switch-from
chromium
actual 695 <- [742 - 787 - 875] -> 1248 507 <- [533 - 549 - 574] -> 663
expected 641 <- [724 - 756 - 895] -> 1033 493 <- [512 - 524 - 535] -> 567
Mean relative change 2.7% ± 3.7% 6.1% ± 1.4%
switch-to
chromium
actual 354 <- [420 - 435 - 455] -> 525 292 <- [315 - 327 - 339] -> 385
expected 343 <- [401 - 421 - 437] -> 588 283 <- [302 - 314 - 324] -> 351
Mean relative change 3.4% ± 2.5% 5.0% ± 1.5%
close
chromium
actual 633 <- [1076 - 1108 - 1150] -> 1298 520 <- [543 - 562 - 583] -> 682
expected 599 <- [1055 - 1079 - 1101] -> 1145 509 <- [528 - 538 - 550] -> 589
Mean relative change 5.0% ± 4.9% 4.9% ± 1.3%

Changes are computed with expected as reference.

@fcollonval fcollonval merged commit 8d7f3f0 into jupyterlab:master Jan 21, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants