New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Links in dialogs are not visually distinct #10837
Labels
Comments
Call me old-school, but I still prefer having links be a different color and underlined to emphasize that they are present in hypertext. |
Incidentally, the message says "Selecting trust will …" (emphasis added) but the action button in the dialog reads "Ok". |
Looks like this was fixed in #11827 |
Awesome, confirmed. Thanks for linking the PR! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Looking into #10836 remained me that the links in popup dialogs are not visually distinct:
"the the Jupyter security documentation" is a link.
Should we change the colours of links and maybe add some other visual indicators?
Here is another example of how a link in a popup is displayed, but with the text equal to the URL:
.
By the way I think that we should avoid using URLs as the text of a link as this might be annoying for screen readers.
Originally posted by @krassowski in #10836 (comment)
The text was updated successfully, but these errors were encountered: