Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix link to the security documentation #10836

Merged
merged 1 commit into from Aug 15, 2021
Merged

Fix link to the security documentation #10836

merged 1 commit into from Aug 15, 2021

Conversation

krassowski
Copy link
Member

@krassowski krassowski commented Aug 15, 2021 •
edited

References

Fixes #10831

Code changes

  • changed both translation strings so that the article is together with the noun,
  • also added target="_blank" and rel="noopener noreferrer" for consistency with other links to RTD docs for safety

User-facing changes

Link works:

Screenshot from 2021-08-15 17-13-28

Backwards-incompatible changes

None

@jupyterlab-dev-mode
Copy link

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@krassowski
Copy link
Member Author

krassowski commented Aug 15, 2021 •
edited

Question: would you agree that we should make the links in popup dialogs visually distinct by changing their colours? Let's discuss it in #10837.

@krassowski krassowski marked this pull request as ready for review August 15, 2021 16:18
@krassowski krassowski mentioned this pull request Aug 15, 2021
Closed
@blink1073 blink1073 added the bug label Aug 15, 2021
@blink1073 blink1073 added this to the 3.1.x milestone Aug 15, 2021
blink1073
blink1073 approved these changes Aug 15, 2021
View reviewed changes
Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@blink1073 blink1073 merged commit 26c35fe into jupyterlab:master Aug 15, 2021
@blink1073
Copy link
Member

@meeseeksdev please backport to 3.1.x

meeseeksmachine pushed a commit to meeseeksmachine/jupyterlab that referenced this pull request Aug 15, 2021
@krassowski @meeseeksmachine
Backport PR jupyterlab#10836: Fix link to the security documentation
e26d25e
@meeseeksmachine meeseeksmachine mentioned this pull request Aug 15, 2021
Merged
blink1073 pushed a commit that referenced this pull request Aug 15, 2021
@meeseeksmachine @krassowski
Backport PR #10836: Fix link to the security documentation (#10838)
e0a6d74 
Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com>
@krassowski krassowski deleted the fix-trust-security-link branch August 16, 2021 08:04
@github-actions github-actions bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Feb 13, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@blink1073 blink1073 blink1073 approved these changes

Assignees

@krassowski krassowski

Labels
bug pkg:notebook status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Milestone
3.1.x
Development

Successfully merging this pull request may close these issues.

Trust this notebook dialog missing linkification
2 participants
@krassowski @blink1073