Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Server extension paths #730

Merged
merged 3 commits into from Mar 14, 2022
Merged

Server extension paths #730

merged 3 commits into from Mar 14, 2022

Commits on Mar 14, 2022

  1. Use app.config_file_path to find server extensions 

    This property in the base class already has the same logic to add config_dir to jupyter_config_path

JupyterHub overrides this to have slightly different logic, and the same should apply here
    @minrk
    minrk committed Mar 14, 2022
    Copy the full SHA
    8e1d67e View commit details
    Browse the repository at this point in the history

  2. extensions should inherit parent's config_file_path 

    base ServerApp should have total control over config file loading
    @minrk
    minrk committed Mar 14, 2022
    Copy the full SHA
    717f22f View commit details
    Browse the repository at this point in the history

  3. ensure ExtensionApp.serverapp is never None 

    Shouldn't ever be accessed without assignment,
but may in cases where ExtensionApps skip initialization and loads config directly
    @minrk
    minrk committed Mar 14, 2022
    Copy the full SHA
    3192e14 View commit details
    Browse the repository at this point in the history