Server extension paths #730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This property in the base class already has the same logic to add config_dir to jupyter_config_path JupyterHub overrides this to have slightly different logic, and the same should apply here
base ServerApp should have total control over config file loading
Shouldn't ever be accessed without assignment, but may in cases where ExtensionApps skip initialization and loads config directly
blink1073
added a commit
to blink1073/jupyter_server
that referenced
this pull request
Mar 14, 2022
This reverts commit 9711822.
blink1073
added a commit
that referenced
this pull request
Mar 14, 2022
minrk
added a commit
to minrk/jupyter_server
that referenced
this pull request
Mar 14, 2022
…-server#732)" This reverts commit 93b1c83.
minrk
added a commit
to minrk/jupyter_server
that referenced
this pull request
Mar 14, 2022
…-server#732)" This reverts commit 93b1c83.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
re-issue #715 with fixes and test for case not handled where ExtensionApps can be instantiated and loaded without being Extensions (#727).