Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce parseable DiscoverySelector representations #3737

Merged
merged 43 commits into from May 17, 2024
Merged

Introduce parseable DiscoverySelector representations #3737

merged 43 commits into from May 17, 2024

Commits on Mar 15, 2024

  1. Initial PoC of DiscoverySelectors.parse

    @leonard84
    leonard84 committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    64be199 View commit details
    Browse the repository at this point in the history

  2. Consistently use DiscoverySelectors methods to reuse validation logic

    @leonard84
    leonard84 committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    21e4886 View commit details
    Browse the repository at this point in the history

  3. Add a DiscoverySelector.toSelectorString() .. 

    to programmatically create valid selector strings,
by creating a selector via DiscoverySelectors.select* and then calling .toSelectorString()
to get the serialized version of it.
    @leonard84
    leonard84 committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    44bca4c View commit details
    Browse the repository at this point in the history

  4. Use URLEncode for all characters in UniqueId segment values 

    Previous to this commit, only a minimal subset of characters has been escaped,
thus leaving the UniqueId unsafe for use in an url.
With the addition of a string representation of selectors based on the URI
format, it has become necessary to make UniqueId url-safe.
Instead of double-encoding the UniqueId, we make the default `toString()` form URL safe.

Still some problems regarding the limits of encoding/decoding
    @leonard84
    leonard84 committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    9eebabd View commit details
    Browse the repository at this point in the history

  5. Add SelectorParserContext

    @leonard84
    leonard84 committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    d824ba7 View commit details
    Browse the repository at this point in the history

  6. Fix deprecations and code style issues

    @leonard84
    leonard84 committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    3c00a82 View commit details
    Browse the repository at this point in the history

  7. spotlessApply

    @leonard84
    leonard84 committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    5b6d01b View commit details
    Browse the repository at this point in the history

  8. Introduce TBD as replacement of URI

    @leonard84
    leonard84 committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    a51c09b View commit details
    Browse the repository at this point in the history

  9. Revert "Use URLEncode for all characters in UniqueId segment values" 

    This reverts commit 9eebabd
    @leonard84
    leonard84 committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    0bd2e21 View commit details
    Browse the repository at this point in the history

  10. Remove UriEncoding again

    @leonard84
    leonard84 committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    360bacc View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2024

  1. Rename TBD to DiscoverySelectorIdentifier

    @marcphilipp
    marcphilipp committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    d64e235 View commit details
    Browse the repository at this point in the history

  2. Allow covariant return types to avoid casting

    @marcphilipp
    marcphilipp committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    9312afe View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main'

    @marcphilipp
    marcphilipp committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    a5545e4 View commit details
    Browse the repository at this point in the history

  4. Make selectors return identifiers

    @marcphilipp
    marcphilipp committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    9d91596 View commit details
    Browse the repository at this point in the history

  5. Add more tests and fix implementations

    @marcphilipp
    marcphilipp committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    a114a29 View commit details
    Browse the repository at this point in the history

  6. Introduce --select and revamp --select-iteration to use identifiers

    @marcphilipp
    marcphilipp committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    e0a3f45 View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2024

  1. Reuse fully-qualified method name utilities for method selectors

    @marcphilipp
    marcphilipp committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    0ffc4c9 View commit details
    Browse the repository at this point in the history

  2. Introduce StringUtils.splitIntoTwo to reduce duplication

    @marcphilipp
    marcphilipp committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    9e8ffd8 View commit details
    Browse the repository at this point in the history

  3. Change parser to return Optional rather than Stream

    @marcphilipp
    marcphilipp committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    ee4707f View commit details
    Browse the repository at this point in the history

  4. Reuse selectMethod(String)

    @marcphilipp
    marcphilipp committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    6f542f0 View commit details
    Browse the repository at this point in the history

  5. Add Javadoc

    @marcphilipp
    marcphilipp committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    f391f83 View commit details
    Browse the repository at this point in the history

  6. Fix module descriptor

    @marcphilipp
    marcphilipp committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    a80e505 View commit details
    Browse the repository at this point in the history

  7. Revert accidental side effect of rename

    @marcphilipp
    marcphilipp committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    4fdca80 View commit details
    Browse the repository at this point in the history

  8. Add TODO

    @marcphilipp
    marcphilipp committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    fe9cd57 View commit details
    Browse the repository at this point in the history

  9. Polish formatting

    @marcphilipp
    marcphilipp committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    720583b View commit details
    Browse the repository at this point in the history

  10. Mark parsers internal

    @marcphilipp
    marcphilipp committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    252f02f View commit details
    Browse the repository at this point in the history

  11. Mark toIdentifier() experimental

    @marcphilipp
    marcphilipp committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    b0343b7 View commit details
    Browse the repository at this point in the history

  12. Polishing

    @marcphilipp
    marcphilipp committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    8d4644a View commit details
    Browse the repository at this point in the history

Commits on May 1, 2024

  1. Polishing

    @marcphilipp
    marcphilipp committed May 1, 2024
    Configuration menu
    Copy the full SHA
    bc80531 View commit details
    Browse the repository at this point in the history

  2. Add tests for CollectionUtils#getFirstElement

    @marcphilipp
    marcphilipp committed May 1, 2024
    Configuration menu
    Copy the full SHA
    9aeec78 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/main' into leo/discovery-selecto… 

    …rs-parse
    @marcphilipp
    marcphilipp committed May 1, 2024
    Configuration menu
    Copy the full SHA
    5b3f23a View commit details
    Browse the repository at this point in the history

  4. Add to release notes

    @marcphilipp
    marcphilipp committed May 1, 2024
    Configuration menu
    Copy the full SHA
    9ce4e20 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2024

  1. Load parsers at most once per class loader 

    By using the enum singleton pattern.
    @marcphilipp
    marcphilipp committed May 15, 2024
    Configuration menu
    Copy the full SHA
    9967df6 View commit details
    Browse the repository at this point in the history

  2. Add explicit anchors

    @marcphilipp
    marcphilipp committed May 15, 2024
    Configuration menu
    Copy the full SHA
    0c14cc6 View commit details
    Browse the repository at this point in the history

  3. Document discovery selectors in User Guide

    @marcphilipp
    marcphilipp committed May 15, 2024
    Configuration menu
    Copy the full SHA
    6143133 View commit details
    Browse the repository at this point in the history

  4. Add todo

    @marcphilipp
    marcphilipp committed May 15, 2024
    Configuration menu
    Copy the full SHA
    4dc3a7c View commit details
    Browse the repository at this point in the history

  5. Reduce table width

    @marcphilipp
    marcphilipp committed May 15, 2024
    Configuration menu
    Copy the full SHA
    27d1542 View commit details
    Browse the repository at this point in the history

  6. Add links to Javadoc

    @marcphilipp
    marcphilipp committed May 15, 2024
    Configuration menu
    Copy the full SHA
    964c27b View commit details
    Browse the repository at this point in the history

  7. Delete empty paragraph

    @marcphilipp
    marcphilipp committed May 15, 2024
    Configuration menu
    Copy the full SHA
    a31381c View commit details
    Browse the repository at this point in the history

  8. Add type-level Javadoc

    @marcphilipp
    marcphilipp committed May 15, 2024
    Configuration menu
    Copy the full SHA
    81b6694 View commit details
    Browse the repository at this point in the history

Commits on May 16, 2024

  1. Introduce Select annotation for test suites

    @marcphilipp
    marcphilipp committed May 16, 2024
    Configuration menu
    Copy the full SHA
    0688942 View commit details
    Browse the repository at this point in the history

  2. Collapse index ranges when formatting iteration selector identifiers

    @marcphilipp
    marcphilipp committed May 16, 2024
    Configuration menu
    Copy the full SHA
    2bd52e1 View commit details
    Browse the repository at this point in the history

  3. Link to suite annotation Javadoc

    @marcphilipp
    marcphilipp committed May 16, 2024
    Configuration menu
    Copy the full SHA
    a7f4868 View commit details
    Browse the repository at this point in the history