Add parseable DiscoverySelector representations #3737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to programmatically create valid selector strings, by creating a selector via DiscoverySelectors.select* and then calling .toSelectorString() to get the serialized version of it.
Previous to this commit, only a minimal subset of characters has been escaped, thus leaving the UniqueId unsafe for use in an url. With the addition of a string representation of selectors based on the URI format, it has become necessary to make UniqueId url-safe. Instead of double-encoding the UniqueId, we make the default `toString()` form URL safe. Still some problems regarding the limits of encoding/decoding
This reverts commit 9eebabd
mpkorstanje
reviewed
Mar 18, 2024
...-platform-engine/src/main/java/org/junit/platform/engine/discovery/NestedMethodSelector.java
Outdated
Show resolved
Hide resolved
marcphilipp
force-pushed
the
leo/discovery-selectors-parse
branch
from
2e8b766
to
252f02f
Compare
|
@marcphilipp, it looks good, what is missing? Or, are you waiting for me to switch it from draft to rfr? |
|
@leonard84 Yes, it does look good and I will finish it for 5.11 M2. |
marcphilipp
reviewed
May 1, 2024
| */ | ||
| @API(status = EXPERIMENTAL, since = "1.11") | ||
| public static Optional<? extends DiscoverySelector> parse(String identifier) { | ||
| return new DiscoverySelectorIdentifierParsers().parse(identifier); |
There was a problem hiding this comment.
Creating a new instance of DiscoverySelectorIdentifierParsers here which leads to a new ServiceLoader lookup and instantiation does not feel right here. I don't think we should make it static, though. Thoughts?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Before this PR, it was not possible to use the more advanced
DiscoverySelectorswithout writing code. Now, we have a generic way to specify all supportedDiscoverySelectorsas strings and parse them.This will allow advanced usage scenarios. For example, Gradle can add a
Testtask parameter to pass a custom selector directly to the platform. This would allow using theIterationSelectorwhen delegating to Gradle in IDEA.I hereby agree to the terms of the JUnit Contributor License Agreement.
Definition of Done
@APIannotations