Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resource container selector resolver #3718

Draft
wants to merge 16 commits into
base: main
Choose a base branch
from

Commits on Feb 25, 2024

  1. Configuration menu
    Copy the full SHA
    02ef108 View commit details
    Browse the repository at this point in the history
  2. Formatting

    mpkorstanje committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    2f76493 View commit details
    Browse the repository at this point in the history
  3. Doc

    mpkorstanje committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    277272a View commit details
    Browse the repository at this point in the history
  4. Fix

    mpkorstanje committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    f683deb View commit details
    Browse the repository at this point in the history

Commits on Feb 29, 2024

  1. Clean up todos

    mpkorstanje committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    c457b58 View commit details
    Browse the repository at this point in the history
  2. Clean up todos

    mpkorstanje committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    c9b3b0e View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2024

  1. Clean up

    mpkorstanje committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    e5a1751 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2bab069 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f34c4c9 View commit details
    Browse the repository at this point in the history
  4. Docs

    mpkorstanje committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    c84ad5e View commit details
    Browse the repository at this point in the history
  5. Tests

    mpkorstanje committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    e43258e View commit details
    Browse the repository at this point in the history
  6. Spotless

    mpkorstanje committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    c374b93 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    440e0e7 View commit details
    Browse the repository at this point in the history
  8. Update CHANGELOG

    mpkorstanje committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    6cca62a View commit details
    Browse the repository at this point in the history
  9. Update CHANGELOG

    mpkorstanje committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    704e584 View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2024

  1. Resolve resource container selectors

    As a follow up for junit-team#3630 and junit-team#3705 this adds a
    `addResourceContainerSelectorResolver()`
    method to `EngineDiscoveryRequestResolver.Builder` analogous to
    `addClassContainerSelectorResolver()`.
    
    Points of note:
    
     * As classpath resources can be selected from packages, the package
       filter should also be applied. To make this possible the base path of
       a resource is rewritten to a package name prior to being filtered.
    
     * The `ClasspathResourceSelector` now has a `getClasspathResource`
       method. This method will lazily try to load the resource if not was
       not already provided when discovering resources in a container.
    
     * `selectClasspathResource(Resource)` was added to short circuit the
        need to resolve resources twice. And to make it possible to use
        this method as part of the public API,
        `ReflectionSupport.tryToLoadResource` was also added.
    mpkorstanje committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    9cbc960 View commit details
    Browse the repository at this point in the history