New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add resource container selector resolver #3718
Draft
mpkorstanje
wants to merge
16
commits into
junit-team:main
Choose a base branch
from
mpkorstanje:add-resource-container-selector-resolver
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Add resource container selector resolver #3718
mpkorstanje
wants to merge
16
commits into
junit-team:main
from
mpkorstanje:add-resource-container-selector-resolver
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As a follow up for junit-team#3630 and junit-team#3705 this adds a `addResourceContainerSelectorResolver()` method to `EngineDiscoveryRequestResolver.Builder` analogous to `addClassContainerSelectorResolver()`. Points of note: * As classpath resources can be selected from packages, the package filter should also be applied. To make this possible the base path of a resource is rewritten to a package name prior to being filtered. * The `ClasspathResourceSelector` now has a `getClasspathResource` method. This method will lazily try to load the resource if not was not already provided when discovering resources in a container. * `selectClasspathResource(Resource)` was added to short circuit the need to resolve resources twice. And to make it possible to use this method as part of the public API, `ReflectionSupport.tryToLoadResource` was also added.
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Resolve resource container selectors
As a follow up for #3630 and #3705 this adds a
addResourceContainerSelectorResolver()
method to
EngineDiscoveryRequestResolver.Builder
analogous toaddClassContainerSelectorResolver()
.Points of note:
As classpath resources can be selected from packages, the package
filter should also be applied. To make this possible the base path of
a resource is rewritten to a package name prior to being filtered.
The
ClasspathResourceSelector
now has agetClasspathResource
method. This method will lazily try to load the resource if not was
not already provided when discovering resources in a container.
selectClasspathResource(Resource)
was added to short circuit theneed to resolve resources twice. And to make it possible to use
this method as part of the public API,
ReflectionSupport.tryToLoadResource
was also added.I hereby agree to the terms of the JUnit Contributor License Agreement.
Definition of Done
@API
annotations