-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to RangeSources #670
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
No automated checks? 😭 |
strange actually the branch should be covered within junit-pioneer/.github/workflows/build.yml Lines 13 to 19 in d9e926e
maybe we remove the branches directive as it is redundant anyways, see https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#running-your-workflow-based-on-the-head-or-base-branch-of-a-pull-request // EDIT: looks like we do have a bug in the yml and it should be actually |
I checked that in history, but it has always be single star. I opened #673 for the bug (to don't have it mixed with this PR) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I checked docs and there is no way about repeatable annotation. Maybe we should add a sentence or two?
There was documentation about this feature in the deprecated |
I was thinking about explicity say, that it is not repeatable anymore (as it was in the old one). Like some kind of migration guide note. |
From a practical standpoint, it was never repeatable in the RangeSource context because the RangeSource extension throws an |
Please provide a commit message, so we can merge / close this :) |
Closes #671
Proposed commit message:
TODO:
RangeSource
annotations with a singleParameterizedTest
?PR checklist
The following checklist shall help the PR's author, the reviewers and maintainers to ensure the quality of this project.
It is based on our contributors guidelines, especially the "writing code" section.
It shall help to check for completion of the listed points.
If a point does not apply to the given PR's changes, the corresponding entry can be simply marked as done.
Documentation (general)
.adoc
file in thedocs
folder, e.g.docs/report-entries.adoc
.adoc
file references demo insrc/demo/java
instead of containing code blocks as text.adoc
files)Documentation (new extension)
docs/docs-nav.yml
navigation has an entry for the new extensionpackage-info.java
contains information about the new extensionCode
Contributing
README.md
mentions the new contribution (real name optional)