Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build pipeline workflow does not trigger #673

Closed
Bukama opened this issue Sep 26, 2022 · 6 comments · Fixed by #674
Closed

Build pipeline workflow does not trigger #673

Bukama opened this issue Sep 26, 2022 · 6 comments · Fixed by #674

Comments

@Bukama
Copy link
Member

Bukama commented Sep 26, 2022

The build pipeline does not trigger.
According to @aepfli we introduced a bug in the branches section

// EDIT: looks like we do have a bug in the yml and it should be actually **

@Bukama
Copy link
Member Author

Bukama commented Sep 26, 2022

I don't think it has to be a double star as @aepfli thought. Git history shows that we have used a single star for pull request since ages.

@aepfli
Copy link
Member

aepfli commented Sep 26, 2022

Yeah but * matches simple paths like main - be aware for pull requests it is the target branch ;) - but not branches with "nested paths" like lab/name

@Michael1993
Copy link
Member

I like just removing the branches line - as far as I understood it's a filtering option where we don't want to do filtering.

@aepfli
Copy link
Member

aepfli commented Sep 27, 2022

Should we do a separate pr, or is it acceptable that we fix this with #670?

@Michael1993
Copy link
Member

For me it's acceptable - it's really minor, does not affect anyone outside the project and we (kind of) already agreed on the solution.

@Bukama
Copy link
Member Author

Bukama commented Sep 27, 2022

I vote for a separate PR to identify the commit with the fix easier in the future (I would not assume that it's in a commit name "update range sources").

@Michael1993 Michael1993 linked a pull request Sep 28, 2022 that will close this issue
14 tasks
Michael1993 added a commit that referenced this issue Sep 28, 2022
This commit removes the branch filtering on PRs. It prevented the
build pipeline from triggering in certain cases but we want to
trigger it for all PRs, so the filtering just did not make sense.

Closes: #673
PR: #674
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants