Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Untangle CartesianTestNameFormatter from ParameterizedTest #533

Merged
merged 3 commits into from Nov 14, 2021
Merged

Untangle CartesianTestNameFormatter from ParameterizedTest #533

merged 3 commits into from Nov 14, 2021

Conversation

Michael1993
Copy link
Member

@Michael1993 Michael1993 commented Nov 8, 2021 •
edited

Proposed commit message:

Untangle CartesianTestNameFormatter (#382 / #533)

CartesianTestNameFormatter no longer references constants used by
Jupiter's ParameterizedTest.

Closes: #382
PR: #533

I hereby agree to the terms of the JUnit Pioneer Contributor License Agreement.

@Michael1993 Michael1993 added the full-build Triggers full build suite on PR label Nov 8, 2021
@beatngu13 beatngu13 mentioned this pull request Nov 10, 2021
Closed
beatngu13
beatngu13 reviewed Nov 10, 2021
View reviewed changes
Copy link
Member

@beatngu13 beatngu13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but is that decoupling necessary? We already have a dependency on JUnit Jupiter and reuse its parameterized formatting?

@nipafx
Copy link
Member

nipafx commented Nov 14, 2021

Can be merged once everything's green. ✅

@nipafx nipafx merged commit a7efc1c into main Nov 14, 2021
@Michael1993 Michael1993 deleted the issue/382-untangle-cartesian-name-formatter branch November 14, 2021 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beatngu13 beatngu13 beatngu13 left review comments

Assignees
No one assigned
Labels
full-build Triggers full build suite on PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Michael1993 @nipafx @beatngu13