Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable environment variable tests on Java 17+ #534

Closed
beatngu13 opened this issue Nov 10, 2021 · 0 comments · Fixed by #535
Closed

Disable environment variable tests on Java 17+ #534

beatngu13 opened this issue Nov 10, 2021 · 0 comments · Fixed by #535
Assignees
@beatngu13
Labels
⚙️ component: Pioneer Issues about Pioneer own things (e.g. utils) 🚦 status: in progress 📖 theme: build 🏗️ type: task

Comments

@beatngu13
Copy link
Member

While reviewing #533 I realized a bunch of failing tests:

https://github.com/junit-pioneer/junit-pioneer/runs/4137127092?check_suite_focus=true#step:8:82

This also happens when re-running current main:

https://github.com/junit-pioneer/junit-pioneer/runs/4158038127?check_suite_focus=true#step:8:82

This is due to #509. Therefore, we should disable the corresponding tests on Java 17+.
@beatngu13 beatngu13 self-assigned this Nov 10, 2021
@beatngu13 beatngu13 mentioned this issue Nov 10, 2021
Merged
13 tasks
beatngu13 added a commit that referenced this issue Nov 11, 2021
@beatngu13
Disable environment variable tests on Java 17+ (#534 / #535)
e669c33 
The environment variable extension / the code under test uses
reflective access to change otherwise immutable environment
variables. On Java 17+, this leads to an
`InaccessibleObjectException`.

See also: #509

Closes: #534
PR: #535
@sleberknight sleberknight mentioned this issue Nov 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@beatngu13 beatngu13

Labels
⚙️ component: Pioneer Issues about Pioneer own things (e.g. utils) 🚦 status: in progress 📖 theme: build 🏗️ type: task
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Disable environment variable tests on Java 17+ junit-pioneer/junit-pioneer
1 participant
@beatngu13