Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ExtensionConfigurationException to DefaultTimeZoneExtension #272

Merged
merged 4 commits into from Jun 20, 2020
Merged

Added ExtensionConfigurationException to DefaultTimeZoneExtension #272

merged 4 commits into from Jun 20, 2020

Conversation

Michael1993
Copy link
Member

Also includes a small documentation fix.
Progresses #164 - which extensions should also be updated this way?


I hereby agree to the terms of the JUnit Pioneer Contributor License Agreement.

Copy link
Member

@Bukama Bukama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I only have two small things I request a change on please.

@Bukama Bukama added this to the Cleaner Pioneers - V1.0 milestone Jun 11, 2020
Copy link
Member

@Bukama Bukama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank your :)
LGTM! 👍

@Bukama Bukama requested a review from aepfli June 19, 2020 16:27
@sonarcloud
Copy link

sonarcloud bot commented Jun 20, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@nipafx nipafx merged commit 4da75d5 into junit-pioneer:master Jun 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants