-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Require configuration failiure tests? #164
Comments
I my opinion it's important that a functioniality checks all of its parts. That's why I tried to check the annotation when I was trying to create the |
As nobody argues against this I remove the |
Note: Aside from the opened PR in #272 I would like to create a list of all extension which lack of such tests, so we have an overview before starting (and maybe doing double work). As I don't have much time at the moment, feel free to have a look at the code and add such a list here - thank you. |
If I have not overseen anything this should be the extensions which as of today (don't) check if the configuration is correct: Checks config:
Does not check / do they need to?
@Michael1993 , @beatngu13 @NPException Did I oversee anything? |
For the `DefaultTimeZoneExtension´ @Michael1993 has opened PR #272 . The other is still up for grabs. |
With the update to JUnit 5.5, we can now use the `InvocationInterceptor` extension point to push test execution onto a separate thread that we can abandon when the specified timeout runs out. Somewhat surprisingly, using Jupiter's `Assertions::assertTimeoutPreemptively` worked really well for that. The extension now also throws `ExtensionConfigurationException` if the specified timeout is negative. Closes: #10 References: #164 PR: #280
Some extensions have tests that check whether broken configurations are handled as expected (e.g.
DefaultLocaleTests
). Should all extensions do that? (E.g.DefaulTimeZoneTests
, which doesn't at the moment.)The text was updated successfully, but these errors were encountered: