[Fix] prefer-read-only-props: avoid crash from #3064

See #3068
jsx-eslint · Sep 5, 2021 · 230ffe1 · 230ffe1
1 parent 9325fa5
commit 230ffe1
Show file tree

Hide file tree

Showing 2 changed files with 35 additions and 4 deletions.
diff --git a/lib/rules/prefer-read-only-props.js b/lib/rules/prefer-read-only-props.js
@@ -51,7 +51,7 @@ module.exports = {
         Object.keys(component.declaredPropTypes).forEach((propName) => {
           const prop = component.declaredPropTypes[propName];
 
-          if (!isFlowPropertyType(prop.node)) {
+          if (!prop.node || !isFlowPropertyType(prop.node)) {
             return;
           }
 

diff --git a/tests/lib/rules/prefer-read-only-props.js b/tests/lib/rules/prefer-read-only-props.js
@@ -29,7 +29,7 @@ const parserOptions = {
 const ruleTester = new RuleTester({parserOptions});
 ruleTester.run('prefer-read-only-props', rule, {
 
-  valid: [
+  valid: [].concat(
     {
       // Class component with type parameter
       code: `
@@ -162,8 +162,39 @@ ruleTester.run('prefer-read-only-props', rule, {
         }
       `,
       parser: parsers.BABEL_ESLINT
-    }
-  ],
+    },
+    parsers.TS([{
+      code: `
+        import React from "react";
+
+        interface Props {
+          name: string;
+        }
+        
+        const MyComponent: React.FC<Props> = ({ name }) => {
+          return <div>{name}</div>;
+        };
+        
+        export default MyComponent;
+      `,
+      parser: parsers.TYPESCRIPT_ESLINT
+    }, {
+      code: `
+        import React from "react";
+
+        interface Props {
+          name: string;
+        }
+        
+        const MyComponent: React.FC<Props> = ({ name }) => {
+          return <div>{name}</div>;
+        };
+        
+        export default MyComponent;
+      `,
+      parser: parsers['@TYPESCRIPT_ESLINT']
+    }])
+  ),
 
   invalid: [
     {