[Fix] propTypes, no-unused-prop-types: remove the fake node add…

…ed in #3064 Fixes #3068
jsx-eslint · Sep 5, 2021 · 9325fa5 · 9325fa5
1 parent 952a768
commit 9325fa5
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 2 deletions.
diff --git a/lib/util/propTypes.js b/lib/util/propTypes.js
@@ -764,7 +764,6 @@ module.exports = function propTypesInstructions(context, components, utils) {
         this.declaredPropTypes.children = {
           fullName: 'children',
           name: 'children',
-          node: {},
           isRequired: false
         };
       }

diff --git a/lib/util/usedPropTypes.js b/lib/util/usedPropTypes.js
@@ -454,7 +454,7 @@ module.exports = function usedPropTypesInstructions(context, components, utils)
     Object.keys(propTypes).forEach((key) => {
       const node = propTypes[key].node;
 
-      if (node.value && astUtil.isFunctionLikeExpression(node.value)) {
+      if (node && node.value && astUtil.isFunctionLikeExpression(node.value)) {
         markPropTypesAsUsed(node.value);
       }
     });

diff --git a/tests/lib/rules/no-unused-prop-types.js b/tests/lib/rules/no-unused-prop-types.js
@@ -3908,6 +3908,22 @@ ruleTester.run('no-unused-prop-types', rule, {
         type StateProps = ReturnType<typeof mapStateToProps>
         type DispatchProps = ReturnType<typeof mapDispatchToProps>`,
         parser: parsers['@TYPESCRIPT_ESLINT']
+      },
+      {
+        code: [
+          'import React from "react";',
+          '',
+          'interface Props {',
+          '  name: string;',
+          '}',
+          '',
+          'const MyComponent: React.FC<Props> = ({ name }) => {',
+          '  return <div>{name}</div>;',
+          '};',
+          '',
+          'export default MyComponent;'
+        ].join('\n'),
+        parser: parsers['@TYPESCRIPT_ESLINT']
       }
     ])
   ),