Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start requiring Node.js v12 or higher #3192

Merged
merged 4 commits into from Aug 2, 2021
Merged

Start requiring Node.js v12 or higher #3192

merged 4 commits into from Aug 2, 2021

Commits on Aug 1, 2021

  1. Require Node.js v12 or higher 

    Also stop testing Node.js v15 (since it will EOL soon) and start testing Node.js v16.
    @domenic
    domenic committed Aug 1, 2021
    Configuration menu
    Copy the full SHA
    b56d60c View commit details
    Browse the repository at this point in the history

  2. Move from optimist to yargs for the benchmark runner 

    Since Mocha uses yargs anyway this isn't a significant increase in total dev dependencies
    @domenic
    domenic committed Aug 1, 2021
    Configuration menu
    Copy the full SHA
    af6aa1a View commit details
    Browse the repository at this point in the history

  3. Do not compare compressed PNG 

    Different Node.js versions can use different zlib versions, leading to
different compressed PNG outputs. Instead, decode the PNG to compare the
pixels directly.
    @TimothyGu @domenic
    TimothyGu authored and domenic committed Aug 1, 2021
    Configuration menu
    Copy the full SHA
    0b42ccf View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2021

  1. Update dependencies and dev dependencies 

    Notably removing the "wd" dev dependency which seems to be no longer used.
    @domenic
    domenic committed Aug 2, 2021
    Configuration menu
    Copy the full SHA
    e90b26d View commit details
    Browse the repository at this point in the history