Start requiring Node.js v12 or higher #3192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domenic
changed the title
TimothyGu
approved these changes
May 23, 2021
Also stop testing Node.js v15 (since it will EOL soon) and start testing Node.js v16.
Since Mocha uses yargs anyway this isn't a significant increase in total dev dependencies
Different Node.js versions can use different zlib versions, leading to different compressed PNG outputs. Instead, decode the PNG to compare the pixels directly.
|
Hmm gonna need to make some updates for https://github.com/websockets/ws/releases/tag/8.0.0 |
|
I'm not sure why the wss variant of Create-blocked-port.any.js was marked as passing before, but with the upgrade it started failing like the normal (ws) variant, so I've marked it as such. |
Notably removing the "wd" dev dependency which seems to be no longer used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this will cause a major version bump. See individual commits for more details.