Calculate MD5 for each S3 multipart upload incrementally #672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalc
force-pushed
the
calculate-s3-md5-incrementally
branch
3 times, most recently
from
9fd9ab1
to
1b31762
Compare
If ContentMD5 is not passed, botocore process the entire file to work out the MD5 for the upload to S3: https://github.com/boto/botocore/blob/1ae092ed95b39c3336ba48c5cbd71b7c37924d05/botocore/handlers.py#L200 It's likely better in many situations to calculate the MD5 for each set of bytes as they come in: the data is already in memory/caches. For event-loop based applications, where file io is often still blocking, this is especially valuable: botocore would block the event loop when it tried to calculate MD5.
michalc
force-pushed
the
calculate-s3-md5-incrementally
branch
from
1b31762
to
71e303b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If ContentMD5 is not passed, botocore process the entire file to work out the MD5 for the upload to S3:
https://github.com/boto/botocore/blob/1ae092ed95b39c3336ba48c5cbd71b7c37924d05/botocore/handlers.py#L200
It's likely better in many situations to calculate the MD5 for each set of bytes as they come in: the data is already in memory/caches.
For event-loop based applications, where file io is often still blocking, this is especially valuable: botocore would block the event loop when it tried to calculate MD5.