Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Calculate MD5 for each S3 multipart upload incrementally
If ContentMD5 is not passed, botocore process the entire file to work out the MD5 for the upload to S3: https://github.com/boto/botocore/blob/1ae092ed95b39c3336ba48c5cbd71b7c37924d05/botocore/handlers.py#L200 It's likely better in many situations to calculate the MD5 for each set of bytes as they come in: the data is already in memory. For event-loop based applications (where file io is not patches to yield the event loop) this is especially valuable. This change avoids botocore blocking the event loop during the MD5 calculation of the entire file.
- Loading branch information
Showing
3 changed files
with
25 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters