[s3] Fix newlines test for python 3.11 and above #1400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SpooledTemporaryFile introduced new changes in 3.11 (https://docs.python.org/3/library/tempfile.html) It now fully implements the io.BufferedIOBase and io.TextIOBase abstract base classes allowing the file to be readable in the mode that it was specified (without accessing the underlying ._file object). It seems like wrapping the underlying ._file is forbidden for versions 3.11 and higher (results in the ValueError) Having two have separate methods for different versions isn't the prettiest fix but should suffice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1381 CI Failures for Python 3.11 and above
SpooledTemporaryFileintroduced new changes in 3.11 (https://docs.python.org/3/library/tempfile.html)It now fully implements the
io.BufferedIOBaseandio.TextIOBaseabstract base classes allowing the fileto be readable in the mode that it was specified (without accessing the underlying
._fileobject).It seems like wrapping the underlying
._fileis forbidden for versions 3.11 and higher (results in theValueError)Having two have separate methods for different versions isn't the prettiest fix but should suffice.