[s3] Fix newline handling for text-mode files #1381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jschneier
force-pushed
the
josh/s3-fix-newlines
branch
5 times, most recently
from
ad3f3c4
to
1f9e246
Compare
|
Hello - I will have a look at the test failures sometime today/tomorrow |
|
@skim618 Any updates? |
|
Sorry for the delay. Looking - it seems the issue is related to the changes made in python 3.11 for I've PR'd a Fix and wrote up the possible CI failure cause: #1400 |
jschneier
force-pushed
the
josh/s3-fix-newlines
branch
from
0965403
to
3b06da2
Compare
jschneier
force-pushed
the
josh/s3-fix-newlines
branch
from
3b06da2
to
b5750f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased version of #1352
Closes #1351