Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check if file exists before deleting #1197

Closed
wants to merge 2 commits into from
Closed

check if file exists before deleting #1197

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4c096b7
check if file exists before deleting
jmelloy Dec 1, 2022
f4599bf
Just catch exception, don't call exists
jmelloy Dec 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 4 additions & 1 deletion storages/backends/s3boto3.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -460,7 +460,10 @@ def _save(self, name, content):

def delete(self, name):
name = self._normalize_name(self._clean_name(name))
self.bucket.Object(name).delete()
try:
self.bucket.Object(name).delete()
except Exception as e:
print(e)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check for whatever specific error code there might be and just silence that and re-raise otherwise.

If you check the handling in .exists() and similar you will see what I mean.


def exists(self, name):
name = self._normalize_name(self._clean_name(name))
Expand Down