check if file exists before deleting #1197
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, rather than running |
|
Done |
jschneier
reviewed
Dec 18, 2022
| try: | ||
| self.bucket.Object(name).delete() | ||
| except Exception as e: | ||
| print(e) |
There was a problem hiding this comment.
Can you check for whatever specific error code there might be and just silence that and re-raise otherwise.
If you check the handling in .exists() and similar you will see what I mean.
|
Also, will need to rebase / merge due to conflicts. |
|
Fixed in #1201. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
S3 was failing on first run because the files didn't exist yet, so check that they exist first.