Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for missing docker dir #625

Merged
merged 2 commits into from Feb 7, 2023
Merged

Check for missing docker dir #625

merged 2 commits into from Feb 7, 2023

Conversation

BretFisher
Copy link
Contributor

Docker v23 no longer creates the /etc/docker/ directory, so we need to create it and don't error if it already exists (for older versions).

Copy link

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah
Copy link

We were discussing this, and the /etc/docker directory was previously created as a side-effect of a legacy functionality for schema 2 v1 images ("libtrust"), which created a key.json in this path.

In general, I think this is the correct fix, as this directory is not guaranteed to be present (it's an optional path to store config files). That said, we'll make a change in the .deb and .rpm packages to automatically create an empty directory on installation;

prepare-vms/lib/commands.sh Outdated Show resolved Hide resolved
Co-authored-by: Tianon Gravi <admwiggin@gmail.com>
@jpetazzo jpetazzo merged commit dd6a1ad into jpetazzo:main Feb 7, 2023
@jpetazzo
Copy link
Owner

jpetazzo commented Feb 7, 2023

Good catch, thank you! <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants