[23.0 backport] deb, rpm: add /etc/docker directory #842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neersighted
previously approved these changes
Feb 7, 2023
Previous versions of the engine created this directory as a side-effect of the (legacy) "key.json" file. With the removal of libtrust (and the key.json) file, that directory is no longer created. While the precence of this directory is not needed for the daemon to function, users may expect it to be there, so it there should be no harm in creating it. For scripting purposes, users are still recommended to check if the directory exists or to create it (mkdir -p). This patch adds a .dirs file to create the directory on installation for .deb; https://www.debian.org/doc/manuals/maint-guide/dother.en.html#dirs And adds a %dirs directive for .rpm packages: http://ftp.rpm.org/max-rpm/s1-rpm-inside-files-list-directives.html#S3-RPM-INSIDE-DIR-DIRECTIVE Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit bfab8ec) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
23.0_backport_add_etc_docker
branch
from
11de7ef
to
3d09b7c
Compare
neersighted
approved these changes
Feb 7, 2023
|
green here as well 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous versions of the engine created this directory as a side-effect of the (legacy) "key.json" file. With the removal of libtrust (and the key.json) file, that directory is no longer created.
While the precence of this directory is not needed for the daemon to function, users may expect it to be there, so it there should be no harm in creating it.
This patch adds a .dirs file to create the directory on installation for .deb; https://www.debian.org/doc/manuals/maint-guide/dother.en.html#dirs
And adds a %dirs directive for .rpm packages:
http://ftp.rpm.org/max-rpm/s1-rpm-inside-files-list-directives.html#S3-RPM-INSIDE-DIR-DIRECTIVE
Signed-off-by: Sebastiaan van Stijn github@gone.nl
(cherry picked from commit 86f8d3c)
Signed-off-by: Sebastiaan van Stijn github@gone.nl