Merge recent MRs #139
Merged
Merge recent MRs #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue is noticeable at `millisPerPixel` being between ~ 0.5 & 2.0 the size of `requestAnimationFrame` period. Canvas image update period would be inconsistent - some would last longer, some less, some would get skipped altogether.
Introduced in 86574e
This reverts f1a0a88
No behavior changes
Reduce the amount of checks
This changes behavior a bit - when `render(` is passed a canvas different from `this.canvas`
and when the user calls `render` manually with a custom `time` argument
…der time It would depend on `scrollBackwards` and `fillStyle` being `undefined` or not. Depending on this, it would either continue the line up to the edge of the canvas or leave it at `lastX`. This makes it so that it is always left at `lastX`.
1 task
…tore()`" This reverts commit f7b488e. For some reason in Chromium 95.0.4638.54 (and maybe others) that change caused `render()` CPU time to grow over time. For me on the `examples/example1.html` page it would grow from 0.5ms to 50ms over 5 minutes
3 tasks
|
Thank you so much! I've merged this and will get a release out soon. |
|
Version 1.36.0 has been published. Please take a look and let me know if you see any issues. https://www.npmjs.com/package/smoothie Thanks again 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge #131, #132, #134, #135, #137, #138, WofWca#1
This is so you don't have to worry about merge conflicts.