Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improvement: fill timeSeries to 0 instead of to the bottom of the canvas #140

Merged
merged 1 commit into from Jan 8, 2023
Merged

improvement: fill timeSeries to 0 instead of to the bottom of the canvas #140

merged 1 commit into from Jan 8, 2023

Conversation

WofWca
Copy link
Collaborator

@WofWca WofWca commented Oct 17, 2021 •
edited

Closes #65

TODO:

@WofWca WofWca changed the base branch from master to linedash December 7, 2021 11:09
@WofWca WofWca changed the base branch from linedash to master December 7, 2021 11:09
@WofWca WofWca marked this pull request as ready for review December 7, 2021 11:15
@WofWca WofWca force-pushed the fill-to-0 branch 5 times, most recently from bc8f536 to fc91c7b Compare January 8, 2023 10:05
@socketpair @WofWca
improvement: add fillToBottom option
d86a9db 
to fill timeSeries to 0 instead of to the bottom of the canvas

Closes joewalnes#65

Co-authored-by: WofWca <wofwca@protonmail.com>
@WofWca WofWca merged commit e269d8b into joewalnes:master Jan 8, 2023
@WofWca WofWca deleted the fill-to-0 branch January 8, 2023 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fillStyle + negative minValue = BUG
2 participants
@WofWca @socketpair