Fixes #7818 - Regression: allow HttpChannel.Listener.onResponseBegin to modify response headers #7850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sponse headers Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
joakime
moved this from In progress
to Review in progress
in Jetty 10.0.10/11.0.10 - 🧊 FROZEN 🥶
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
uschindler
previously approved these changes
Apr 6, 2022
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
The 9.4.x test case which shows that this works is in PR #7851 |
joakime
changed the title
gregw
reviewed
Apr 26, 2022
Jetty 10.0.10/11.0.10 - 🧊 FROZEN 🥶
automation
moved this from Review in progress
to Reviewer approved
Jun 1, 2022
sbordet
approved these changes
Jun 1, 2022
olamy
added a commit
that referenced
this pull request
Oct 9, 2022
Signed-off-by: Olivier Lamy <olamy@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7850 - A regression in
HttpChannel.Listener.onResponseBeginwith the ability to modify response headers immediately before commit.See PR #7851 for Jetty 9.4.x test demonstrating behavior. (Jetty 9.4.x does not need a code change)
Signed-off-by: Joakim Erdfelt joakim.erdfelt@gmail.com